Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: content/shell/renderer/layout_test/layout_test_render_thread_observer.h

Issue 1890223002: Explicitly initialize secondary renderers for layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/layout_test_render_thread_observer.h
diff --git a/content/shell/renderer/layout_test/layout_test_render_thread_observer.h b/content/shell/renderer/layout_test/layout_test_render_thread_observer.h
index 945a42001745dcbd4103bec9d25a057ece2b8d06..ba22e2a126c2aa5a6bdd25bc1f9ee3fb9b568f09 100644
--- a/content/shell/renderer/layout_test/layout_test_render_thread_observer.h
+++ b/content/shell/renderer/layout_test/layout_test_render_thread_observer.h
@@ -24,9 +24,6 @@ class WebTestInterfaces;
namespace content {
-class RenderView;
-class BlinkTestRunner;
-
class LayoutTestRenderThreadObserver : public RenderThreadObserver {
public:
static LayoutTestRenderThreadObserver* GetInstance();
@@ -35,7 +32,6 @@ class LayoutTestRenderThreadObserver : public RenderThreadObserver {
~LayoutTestRenderThreadObserver() override;
void SetTestDelegate(test_runner::WebTestDelegate* delegate);
- void SetMainWindow(RenderView* view);
// RenderThreadObserver implementation.
void OnRenderProcessShutdown() override;
@@ -47,14 +43,12 @@ class LayoutTestRenderThreadObserver : public RenderThreadObserver {
test_runner::WebTestInterfaces* test_interfaces() const {
return test_interfaces_.get();
}
- BlinkTestRunner* main_test_runner() const { return main_test_runner_; }
const base::FilePath& webkit_source_dir() const { return webkit_source_dir_; }
private:
// Message handlers.
void OnSetWebKitSourceDir(const base::FilePath& webkit_source_dir);
- BlinkTestRunner* main_test_runner_;
test_runner::WebTestDelegate* test_delegate_;
std::unique_ptr<test_runner::WebTestInterfaces> test_interfaces_;

Powered by Google App Engine
This is Rietveld 408576698