Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: content/shell/browser/layout_test/secondary_test_window_observer.h

Issue 1890223002: Explicitly initialize secondary renderers for layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/secondary_test_window_observer.h
diff --git a/content/shell/browser/layout_test/notify_done_forwarder.h b/content/shell/browser/layout_test/secondary_test_window_observer.h
similarity index 35%
rename from content/shell/browser/layout_test/notify_done_forwarder.h
rename to content/shell/browser/layout_test/secondary_test_window_observer.h
index c512c2472f8605a2ae8bb90acf1d23b1f5acf1c0..b41a95b3c571995f164f4030209d86dae60991b8 100644
--- a/content/shell/browser/layout_test/notify_done_forwarder.h
+++ b/content/shell/browser/layout_test/secondary_test_window_observer.h
@@ -1,9 +1,9 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_NOTIFY_DONE_FORWARDER_H_
-#define CONTENT_SHELL_BROWSER_LAYOUT_TEST_NOTIFY_DONE_FORWARDER_H_
+#ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_SECONDARY_TEST_WINDOW_OBSERVER_H_
+#define CONTENT_SHELL_BROWSER_LAYOUT_TEST_SECONDARY_TEST_WINDOW_OBSERVER_H_
#include "base/macros.h"
#include "content/public/browser/web_contents_observer.h"
@@ -11,24 +11,28 @@
namespace content {
-class NotifyDoneForwarder : public WebContentsObserver,
- public WebContentsUserData<NotifyDoneForwarder> {
+class SecondaryTestWindowObserver
+ : public WebContentsObserver,
+ public WebContentsUserData<SecondaryTestWindowObserver> {
public:
- ~NotifyDoneForwarder() override;
+ ~SecondaryTestWindowObserver() override;
// WebContentsObserver implementation.
bool OnMessageReceived(const IPC::Message& message) override;
+ void RenderFrameCreated(RenderFrameHost* render_frame_host) override;
+ void RenderFrameHostChanged(RenderFrameHost* old_host,
+ RenderFrameHost* new_host) override;
private:
- friend class WebContentsUserData<NotifyDoneForwarder>;
+ friend class WebContentsUserData<SecondaryTestWindowObserver>;
- explicit NotifyDoneForwarder(WebContents* web_contents);
+ explicit SecondaryTestWindowObserver(WebContents* web_contents);
void OnTestFinishedInSecondaryRenderer();
- DISALLOW_COPY_AND_ASSIGN(NotifyDoneForwarder);
+ DISALLOW_COPY_AND_ASSIGN(SecondaryTestWindowObserver);
};
} // namespace content
-#endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_NOTIFY_DONE_FORWARDER_H_
+#endif // CONTENT_SHELL_BROWSER_LAYOUT_TEST_SECONDARY_TEST_WINDOW_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698