Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

Issue 1890223002: Explicitly initialize secondary renderers for layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
index 8fa6569d5278282f9eac1d67f1f394b609f7b0f4..e5cc9a85b0d9c409ec9e128e6649ceabb5544e93 100644
--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
@@ -38,6 +38,8 @@ bool LayoutTestRenderFrameObserver::OnMessageReceived(
OnReplicateTestConfiguration)
IPC_MESSAGE_HANDLER(ShellViewMsg_SetTestConfiguration,
OnSetTestConfiguration)
+ IPC_MESSAGE_HANDLER(ShellViewMsg_SetupSecondaryRenderer,
+ OnSetupSecondaryRenderer)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
@@ -66,8 +68,7 @@ void LayoutTestRenderFrameObserver::OnReplicateTestConfiguration(
const ShellTestConfiguration& test_config,
const base::DictionaryValue&
accumulated_layout_test_runtime_flags_changes) {
- LayoutTestRenderProcessObserver::GetInstance()
- ->main_test_runner()
+ BlinkTestRunner::Get(render_frame()->GetRenderView())
->OnReplicateTestConfiguration(test_config);
OnReplicateLayoutTestRuntimeFlagsChanges(
@@ -76,9 +77,13 @@ void LayoutTestRenderFrameObserver::OnReplicateTestConfiguration(
void LayoutTestRenderFrameObserver::OnSetTestConfiguration(
const ShellTestConfiguration& test_config) {
- LayoutTestRenderProcessObserver::GetInstance()
- ->main_test_runner()
+ BlinkTestRunner::Get(render_frame()->GetRenderView())
->OnSetTestConfiguration(test_config);
}
+void LayoutTestRenderFrameObserver::OnSetupSecondaryRenderer() {
+ BlinkTestRunner::Get(render_frame()->GetRenderView())
+ ->OnSetupSecondaryRenderer();
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698