Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1890223002: Explicitly initialize secondary renderers for layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index b66595d48020b3996c9a1f44df8a37ee831a1cc8..b7c7960c731017017ef8d4878d20c9cbb7149136 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -744,15 +744,6 @@ bool BlinkTestRunner::OnMessageReceived(const IPC::Message& message) {
void BlinkTestRunner::Navigate(const GURL& url) {
focus_on_next_commit_ = true;
- if (!is_main_window_ &&
- LayoutTestRenderProcessObserver::GetInstance()->main_test_runner() ==
- this) {
- test_runner::WebTestInterfaces* interfaces =
- LayoutTestRenderProcessObserver::GetInstance()->test_interfaces();
- interfaces->SetTestIsRunning(true);
- interfaces->ConfigureForTestWithURL(GURL(), false);
- ForceResizeRenderView(render_view(), WebSize(800, 600));
- }
}
void BlinkTestRunner::DidCommitProvisionalLoad(WebLocalFrame* frame,
@@ -904,6 +895,16 @@ BlinkTestRunner::GetBluetoothFakeAdapterSetter() {
return *bluetooth_fake_adapter_setter_;
}
+void BlinkTestRunner::OnSetupSecondaryRenderer() {
+ DCHECK(!is_main_window_);
+
+ test_runner::WebTestInterfaces* interfaces =
+ LayoutTestRenderProcessObserver::GetInstance()->test_interfaces();
+ interfaces->SetTestIsRunning(true);
+ interfaces->ConfigureForTestWithURL(GURL(), false);
+ ForceResizeRenderView(render_view(), WebSize(800, 600));
+}
+
void BlinkTestRunner::OnReplicateTestConfiguration(
const ShellTestConfiguration& params) {
test_config_ = params;

Powered by Google App Engine
This is Rietveld 408576698