net/data/verify_certificate_chain_unittest/generate-expired-root.py - Issue 1890193003: Make Cast certificate verification enforce constraints specified in the trusted root certificate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/verify_certificate_chain_unittest/generate-expired-root.py

Issue 1890193003: Make Cast certificate verification enforce constraints specified in the trusted root certificate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: list datafiles for ios (needed following the rebase) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/verify_certificate_chain_unittest/expired-root.pem ('k') | net/data/verify_certificate_chain_unittest/generate-non-self-signed-root.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/verify_certificate_chain_unittest/generate-expired-root.py

diff --git a/net/data/verify_certificate_chain_unittest/generate-expired-intermediary.py b/net/data/verify_certificate_chain_unittest/generate-expired-root.py

similarity index 68%

copy from net/data/verify_certificate_chain_unittest/generate-expired-intermediary.py

copy to net/data/verify_certificate_chain_unittest/generate-expired-root.py

index 463a37bf0e3e986b7b968d7259dde05556bd26c9..83f79171f37c99041f59c0c101d1a8f072d9b169 100755

--- a/net/data/verify_certificate_chain_unittest/generate-expired-intermediary.py

+++ b/net/data/verify_certificate_chain_unittest/generate-expired-root.py

@@ -1,21 +1,21 @@

#!/usr/bin/python

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-"""Certificate chain with 1 intermediary, where the intermediary is expired

+"""Certificate chain with 1 intermediary, where the root certificate is expired

(violates validity.notAfter). Verification is expected to fail."""

import common

# Self-signed root certificate (part of trust store).

root = common.create_self_signed_root_certificate('Root')

-root.set_validity_range(common.JANUARY_1_2015_UTC, common.JANUARY_1_2016_UTC)

+root.set_validity_range(common.JANUARY_1_2015_UTC, common.MARCH_1_2015_UTC)

# Intermediary certificate.

intermediary = common.create_intermediary_certificate('Intermediary', root)

intermediary.set_validity_range(common.JANUARY_1_2015_UTC,

- common.MARCH_1_2015_UTC)

+ common.JANUARY_1_2016_UTC)

# Target certificate.

target = common.create_end_entity_certificate('Target', intermediary)

@@ -24,8 +24,8 @@ target.set_validity_range(common.JANUARY_1_2015_UTC, common.JANUARY_1_2016_UTC)

chain = [target, intermediary]

trusted = [root]

-# Both the root and target are valid at this time, however the

-# intermediary certificate is not.

+# Both the target and intermediary are valid at this time, however the

+# root is not.

time = common.MARCH_2_2015_UTC

verify_result = False