Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1890133002: [MIPS] Fix gn_unittests LoaderTest.Foo test (Closed)

Created:
4 years, 8 months ago by lmilko
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, petar.jovanovic, gordana.cmiljanovic_imgtec.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MIPS] Fix gn_unittests LoaderTest.Foo test Test was failing with error message: "Check failed: false. OS architecture not handled." This change adds support for executing gn tool on mips platform. BUG=130022 TEST=gn_unittests --gtest_filter=LoaderTest.Foo Committed: https://crrev.com/8ea3910c7dd3289ee7c49223c77032f0936d84bc Cr-Commit-Position: refs/heads/master@{#387868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gn/args.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
lmilko
Please take a look.
4 years, 8 months ago (2016-04-15 14:01:56 UTC) #2
Dirk Pranke
lgtm.
4 years, 8 months ago (2016-04-15 21:13:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890133002/1
4 years, 8 months ago (2016-04-18 07:02:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 07:51:34 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 07:52:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ea3910c7dd3289ee7c49223c77032f0936d84bc
Cr-Commit-Position: refs/heads/master@{#387868}

Powered by Google App Engine
This is Rietveld 408576698