Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1890123002: Reland of Rehash and clear deleted entries in weak collections during GC (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Rehash and clear deleted entries in weak collections during GC BUG=v8:4909 R=hpayer@chromium.org,ulan@chromium.org LOG=n Committed: https://crrev.com/09db5406d41147e71d2f32df6e84c9eefa44dbc8 Cr-Commit-Position: refs/heads/master@{#35538}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M src/objects.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
ptal patchset #1 is original patchset #2 is the fix
4 years, 8 months ago (2016-04-15 13:59:47 UTC) #1
ulan
lgtm
4 years, 8 months ago (2016-04-15 14:01:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890123002/20001
4 years, 8 months ago (2016-04-15 14:02:25 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 14:40:18 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 14:41:16 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/09db5406d41147e71d2f32df6e84c9eefa44dbc8
Cr-Commit-Position: refs/heads/master@{#35538}

Powered by Google App Engine
This is Rietveld 408576698