Compute expected type for variables

Compute expected type for variables

That is, the intersection of all types it will have to be coerced to.

R=jkummerow@chromium.org
BUG=

[Jakob Kummerow, 2013-07-09 16:01:50]

https://codereview.chromium.org/18901003/diff/1/src/typing.cc
File src/typing.cc (right):

https://codereview.chromium.org/18901003/diff/1/src/typing.cc#newcode281
src/typing.cc:281: Type::Intersect(var->expected_type(), expected_type_),
isolate_));
As discussed offline, I still think a Union would make more sense here.

https://codereview.chromium.org/18901003/diff/1/src/typing.cc#newcode355
src/typing.cc:355: RECURSE(Visit(expr->value()));
Shouldn't this be RECURSE_EXPR(_, Type::Any())?

https://codereview.chromium.org/18901003/diff/1/src/typing.cc#newcode384
src/typing.cc:384: RECURSE_EXPR(Visit(expr->key()), Type::Name());
I'm pretty sure that the key can also be a number.

https://codereview.chromium.org/18901003/diff/1/src/variables.h
File src/variables.h (right):

https://codereview.chromium.org/18901003/diff/1/src/variables.h#newcode169
src/variables.h:169: Handle<Type> expected_type_;  // Intersection of all reads
nit: trailing full stop. And, uhm, "Union" ;-)

[Jakob Kummerow, 2015-11-28 15:28:08]

Description was changed from

==========
Compute expected type for variables

That is, the intersection of all types it will have to be coerced to.

R=jkummerow@chromium.org
BUG=
==========

to

==========
Compute expected type for variables

That is, the intersection of all types it will have to be coerced to.

R=jkummerow@chromium.org
BUG=
==========