Immediately cache compiled scripts.

Immediately cache compiled scripts.

Usually, script compilation is expensive enough to warrant the extra
overhead of caching scripts immediatly.

BUG=chromium:588900
R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/3533c084d470912384988768c4b3b109304da357
Cr-Commit-Position: refs/heads/master@{#35527}

[jochen (gone - plz use gerrit), 2016-04-15 11:54:20]

ptal

[Yang, 2016-04-15 12:03:38]

lgtm with comment.

https://codereview.chromium.org/1890083002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1890083002/diff/1/src/objects.cc#newcode17632
src/objects.cc:17632: int entry = cache->FindEntry(&key);
I don't think this code path is actually possible. We only put a new entry into
the cache if we haven't found it previously. You could implement this just like
PutRegExp below.

[jochen (gone - plz use gerrit), 2016-04-15 12:11:37]

Description was changed from

==========
Immediately cache compiled scripts.

Usually, script compilation is expensive enough to warrant the extra
overhead of caching scripts immediatly.

BUG=chromium:588900
R=yangguo@chromium.org
==========

to

==========
Immediately cache compiled scripts.

Usually, script compilation is expensive enough to warrant the extra
overhead of caching scripts immediatly.

BUG=chromium:588900
R=yangguo@chromium.org
LOG=n
==========

[jochen (gone - plz use gerrit), 2016-04-15 12:11:50]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-04-15 12:11:50]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1890083002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2016-04-15 12:12:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1890083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1890083002/20001

[commit-bot: I haz the power, 2016-04-15 12:51:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-15 12:53:45]

Description was changed from

==========
Immediately cache compiled scripts.

Usually, script compilation is expensive enough to warrant the extra
overhead of caching scripts immediatly.

BUG=chromium:588900
R=yangguo@chromium.org
LOG=n
==========

to

==========
Immediately cache compiled scripts.

Usually, script compilation is expensive enough to warrant the extra
overhead of caching scripts immediatly.

BUG=chromium:588900
R=yangguo@chromium.org
LOG=n

Committed: https://crrev.com/3533c084d470912384988768c4b3b109304da357
Cr-Commit-Position: refs/heads/master@{#35527}
==========

[commit-bot: I haz the power, 2016-04-15 12:53:46]

Patchset 2 (id:??) landed as
https://crrev.com/3533c084d470912384988768c4b3b109304da357
Cr-Commit-Position: refs/heads/master@{#35527}

[Michael Achenbach, 2016-04-15 14:19:25]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1882833006/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/buil...

Auto-bisect points to this CL..

[Michael Achenbach, 2016-04-15 14:24:14]

This also seems to break webkit_unit_tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...