build/vs_toolchain.py - Issue 1890053004: Stop gyp_chromium prior to mass DLL copies on error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/vs_toolchain.py

Issue 1890053004: Stop gyp_chromium prior to mass DLL copies on error (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/vs_toolchain.py

diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py

index 12e86546870258eb3b366c9db43a3938e34512e0..a9bd0760e744b812d4dc66ad2a155ace3632561d 100755

--- a/build/vs_toolchain.py

+++ b/build/vs_toolchain.py

@@ -158,7 +158,7 @@ def _CopyRuntimeImpl(target, source, verbose=True):

"""

if (os.path.isdir(os.path.dirname(target)) and

(not os.path.isfile(target) or

- os.stat(target).st_mtime != os.stat(source).st_mtime)):

+ os.stat(target).st_mtime != os.stat(source).st_mtime)):

gab 2016/04/15 19:11:24 Seems to already be supposed to skip if files have

if verbose:

print 'Copying %s to %s...' % (source, target)

if os.path.exists(target):

« no previous file with comments | « build/gyp_chromium.py ('k') | no next file » | no next file with comments »