Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1890023002: Revert of mac: Remove POSIX shared memory. (Closed)

Created:
4 years, 8 months ago by shrike
Modified:
4 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, gavinp+memory_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp50_base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Remove POSIX shared memory. (patchset #8 id:140001 of https://codereview.chromium.org/1867733002/ ) Reason for revert: Looking for the cause of https://crbug.com/603452. Original issue's description: > mac: Remove POSIX shared memory. > > There are no more consumers. > > BUG=568284 > > Committed: https://crrev.com/acc9ec9e73902650962df0c24a209abfc2a827ef > Cr-Commit-Position: refs/heads/master@{#387050} TBR=mark@chromium.org,mseaborn@chromium.org,avi@chromium.org,tsepez@chromium.org,amistry@chromium.org,thakis@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=568284 NOPRESUBMIT=true Committed: https://crrev.com/6b5d3ac9b231cbd56dcbea0bcdf94b3e9178e738 Cr-Commit-Position: refs/heads/master@{#387482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+723 lines, -124 lines) Patch
M base/memory/shared_memory.h View 6 chunks +23 lines, -5 lines 0 comments Download
M base/memory/shared_memory_handle.h View 4 chunks +63 lines, -16 lines 0 comments Download
M base/memory/shared_memory_handle_mac.cc View 4 chunks +140 lines, -42 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 8 chunks +241 lines, -20 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 8 chunks +18 lines, -5 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +75 lines, -25 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 2 chunks +136 lines, -0 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer.cc View 3 chunks +17 lines, -3 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
shrike
Created Revert of mac: Remove POSIX shared memory.
4 years, 8 months ago (2016-04-14 22:54:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890023002/1
4 years, 8 months ago (2016-04-14 22:54:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890023002/1
4 years, 8 months ago (2016-04-14 23:01:40 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/168889)
4 years, 8 months ago (2016-04-14 23:10:07 UTC) #5
erikchen
On 2016/04/14 23:10:07, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-14 23:14:24 UTC) #6
shrike
On 2016/04/14 23:14:24, erikchen wrote: > On 2016/04/14 23:10:07, commit-bot: I haz the power wrote: ...
4 years, 8 months ago (2016-04-14 23:31:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890023002/1
4 years, 8 months ago (2016-04-14 23:32:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 00:03:43 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6b5d3ac9b231cbd56dcbea0bcdf94b3e9178e738 Cr-Commit-Position: refs/heads/master@{#387482}
4 years, 8 months ago (2016-04-15 00:06:26 UTC) #14
erikchen
4 years, 8 months ago (2016-04-15 15:39:17 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1893603002/ by erikchen@chromium.org.

The reason for reverting is: The original CL was reverted on suspicion of
causing a crash. It was not responsible.

https://bugs.chromium.org/p/chromium/issues/detail?id=603452.

Powered by Google App Engine
This is Rietveld 408576698