Fix mirrors to keep typedef as scope class of function types (fixes #26187).

Fix mirrors to keep typedef as scope class of function types (fixes #26187).
Add mirror regression test.
Adjust expectation of a mirror test.
Fix parser to mark current class as typedef before parsing signature.
Fix canonicalization of typedef function types (a typedef class can be the scope
class of more than one function type, even if not generic).

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/bab552edaf1080fdca423029128516e1c81a3279

[regis, 2016-04-14 22:37:40]

regis@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[rmacnak, 2016-04-15 16:58:30]

https://chromiumcodereview.appspot.com/1890013002/diff/20001/tests/lib/mirror...
File tests/lib/mirrors/regress_26187_test.dart (right):

https://chromiumcodereview.appspot.com/1890013002/diff/20001/tests/lib/mirror...
tests/lib/mirrors/regress_26187_test.dart:12: typedef void f(@A() int, String);
Add a second typedef with the same signature to the test and check its metadata
is not confused with that of the first typedef. It's clearer than the
side-effect of currentMirrorSystem().libraries.

typedef void g(@B() int, String);

[regis, 2016-04-15 19:32:20]

Thanks!

PTAL

https://chromiumcodereview.appspot.com/1890013002/diff/20001/tests/lib/mirror...
File tests/lib/mirrors/regress_26187_test.dart (right):

https://chromiumcodereview.appspot.com/1890013002/diff/20001/tests/lib/mirror...
tests/lib/mirrors/regress_26187_test.dart:12: typedef void f(@A() int, String);
On 2016/04/15 16:58:30, rmacnak wrote:
> Add a second typedef with the same signature to the test and check its
metadata
> is not confused with that of the first typedef. It's clearer than the
> side-effect of currentMirrorSystem().libraries.
> 
> typedef void g(@B() int, String);

Done.

[rmacnak, 2016-04-15 20:18:27]

LGTM

[regis, 2016-04-15 20:21:25]

Description was changed from

==========
Fix mirrors to keep typedef as scope class of function types (fixes #26187).
Add mirror regression test.
Adjust expectation of a mirror test.
Fix parser to mark current class as typedef before parsing signature.
Fix canonicalization of typedef function types (a typedef class can be the scope
class of more than one function type, even if not generic).
==========

to

==========
Fix mirrors to keep typedef as scope class of function types (fixes #26187).
Add mirror regression test.
Adjust expectation of a mirror test.
Fix parser to mark current class as typedef before parsing signature.
Fix canonicalization of typedef function types (a typedef class can be the scope
class of more than one function type, even if not generic).

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bab552edaf1080fdca423029128516e1c81a3279
==========

[regis, 2016-04-15 20:21:27]

Committed patchset #3 (id:40001) manually as
bab552edaf1080fdca423029128516e1c81a3279 (presubmit successful).