lib/src/channel_manager.dart - Issue 1890003002: Fix a race condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/channel_manager.dart

Issue 1890003002: Fix a race condition. (Closed) Base URL: git@github.com:dart-lang/json_rpc_2.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/channel_manager.dart

diff --git a/lib/src/channel_manager.dart b/lib/src/channel_manager.dart

index 35d75a60814bc80197a4c015c7da6593fdd26505..8f66870735eb4fd81e4c23698fc55174e6b3455d 100644

--- a/lib/src/channel_manager.dart

+++ b/lib/src/channel_manager.dart

@@ -56,7 +56,9 @@ class ChannelManager {

_doneCompleter.completeError(error, stackTrace);

_channel.sink.close();

- onDone: _doneCompleter.complete,

+ onDone: () {

+ if (!_doneCompleter.isCompleted) _doneCompleter.complete();

+ },

cancelOnError: true);

return done;

« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »