Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1889983002: Change string argument type to GetFormatDataValue. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Change string argument type to GetFormatDataValue. Avoid string duplication, since the first thing these routines do is allocate a new string from the static string argument. Committed: https://pdfium.googlesource.com/pdfium/+/6f167c3ea2f8093170cae12a3de4ded76ac521ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M xfa/fxfa/parser/cxfa_widgetdata.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 5 chunks +5 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 6 chunks +6 lines, -7 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tom Sepez
Dan, for review.
4 years, 8 months ago (2016-04-14 21:05:36 UTC) #2
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-14 21:50:37 UTC) #5
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-14 22:17:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889983002/1
4 years, 8 months ago (2016-04-14 22:46:10 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 22:46:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6f167c3ea2f8093170cae12a3de4ded76ac5...

Powered by Google App Engine
This is Rietveld 408576698