Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

Issue 1889973002: Refactoring starting a resource load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
index 57cf31006a1a1d0815b9ebb12486b4521f434d00..6ce433b074568c5121f82a41bd43f7e002469add 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
@@ -113,9 +113,9 @@ TEST_F(ResourceFetcherTest, StartLoadAfterFrameDetach)
EXPECT_EQ(resource, static_cast<Resource*>(nullptr));
EXPECT_EQ(memoryCache()->resourceForURL(secureURL), static_cast<Resource*>(nullptr));
- // Try calling Resource::load directly. This shouldn't crash.
- Resource* resource2 = Resource::create(secureURL, Resource::Raw);
- resource2->load(fetcher);
+ // Start by calling startLoad() directly, rather than via requestResource().
+ // This shouldn't crash.
+ fetcher->startLoad(Resource::create(secureURL, Resource::Raw));
}
TEST_F(ResourceFetcherTest, UseExistingResource)

Powered by Google App Engine
This is Rietveld 408576698