third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp - Issue 1889973002: Refactoring starting a resource load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Issue 1889973002: Refactoring starting a resource load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/elements/styles-1/css-outline-expected.txt ('K') | « third_party/WebKit/Source/core/loader/FrameFetchContext.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

index 02ee60d131298949e15a060e5e8184a51e924410..ab740a953f017c09b7d62eb3bea8850b1a9d9e94 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

@@ -31,6 +31,7 @@

#include "core/loader/FrameFetchContext.h"

#include "core/fetch/FetchInitiatorInfo.h"

+#include "core/fetch/UniqueIdentifier.h"

#include "core/frame/FrameHost.h"

#include "core/frame/FrameOwner.h"

#include "core/frame/FrameView.h"

@@ -571,7 +572,7 @@ TEST_F(FrameFetchContextDisplayedCertificateErrorsTest, MemoryCacheCertificateEr

response.setHasMajorCertificateErrors(true);

Resource* resource = Resource::create(resourceRequest, Resource::Image);

resource->setResponse(response);

- fetchContext->dispatchDidLoadResourceFromMemoryCache(resource, WebURLRequest::FrameTypeNone, WebURLRequest::RequestContextImage);

+ fetchContext->dispatchDidLoadResourceFromMemoryCache(createUniqueIdentifier(), resource, WebURLRequest::FrameTypeNone, WebURLRequest::RequestContextImage);

}

TEST_F(FrameFetchContextTest, SetIsExternalRequestForPublicDocument)