Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1889933003: Revert of [DevTools] Added keyboard search while in sources (Closed)

Created:
4 years, 8 months ago by allada
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Added keyboard search while in sources (patchset #7 id:120001 of https://codereview.chromium.org/1831903002/ ) Reason for revert: Screwed up timeline. Original issue's description: > [DevTools] Added keyboard search while in sources > > While in sources file explorer gives the ability to search/filter files > by typing while panel is not blured. On blur event, click, esc or enter > the filtering will cancel. > > The display underlines the matches found. If the user then uses arrow keys > to navigate up and down only the filtered items should be selectable. > > R=lushnikov,pfeldman > BUG=594654 > > Committed: https://crrev.com/391574fa0e749ba67d59c7b7bdb8eb33624fa355 > Cr-Commit-Position: refs/heads/master@{#387079} TBR=lushnikov@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=594654 Committed: https://crrev.com/07cbcf36835482bb604d95256e0513b24acb10e9 Cr-Commit-Position: refs/heads/master@{#387763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -199 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.css View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js View 8 chunks +18 lines, -193 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
allada
Created Revert of [DevTools] Added keyboard search while in sources
4 years, 8 months ago (2016-04-14 21:41:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889933003/1
4 years, 8 months ago (2016-04-14 21:42:25 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-14 21:42:26 UTC) #4
allada
PTL
4 years, 8 months ago (2016-04-15 18:49:23 UTC) #6
lushnikov
lgtm
4 years, 8 months ago (2016-04-15 18:50:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889933003/1
4 years, 8 months ago (2016-04-15 19:01:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/206005)
4 years, 8 months ago (2016-04-15 22:00:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889933003/1
4 years, 8 months ago (2016-04-15 22:39:40 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 00:20:43 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 00:22:21 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07cbcf36835482bb604d95256e0513b24acb10e9
Cr-Commit-Position: refs/heads/master@{#387763}

Powered by Google App Engine
This is Rietveld 408576698