Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js

Issue 1889913004: [DevTools] Remove network headers filter experiment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
index 69e80ec6f168221bfe6b3de46d82ee624466ae18..7891d10530ada86b81b71d423ae0ec69e3a998c4 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestHeadersView.js
@@ -44,19 +44,6 @@ WebInspector.RequestHeadersView = function(request)
this._showRequestHeadersText = false;
this._showResponseHeadersText = false;
- this._requestHeaderFilterSetting = WebInspector.settings.createSetting("requestHeaderFilterSetting", "");
-
- /** @type {?RegExp} */
- this._filterRegex = null;
- if (Runtime.experiments.isEnabled("networkRequestHeadersFilterInDetailsView")) {
- this._filterInput = this.element.createChild("input", "filter-input");
- this._filterInput.type = "text";
- this._filterInput.placeholder = WebInspector.UIString("Filter headers");
- this._filterInput.addEventListener("input", this._updateFilter.bind(this), false);
- this._filterInput.addEventListener("keydown", this._onFilterKeyDown.bind(this), false);
- this._filterInput.value = this._requestHeaderFilterSetting.get() || "";
- }
-
var root = new TreeOutline(true);
root.element.classList.add("outline-disclosure");
root.expandTreeElementsWhenArrowing = true;
@@ -75,43 +62,9 @@ WebInspector.RequestHeadersView = function(request)
this._queryStringCategory = new WebInspector.RequestHeadersView.Category(root, "queryString", "");
this._formDataCategory = new WebInspector.RequestHeadersView.Category(root, "formData", "");
this._requestPayloadCategory = new WebInspector.RequestHeadersView.Category(root, "requestPayload", WebInspector.UIString("Request Payload"));
-
-
- if (Runtime.experiments.isEnabled("networkRequestHeadersFilterInDetailsView")) {
- this._updateFilter();
- }
}
WebInspector.RequestHeadersView.prototype = {
- _updateFilter: function()
- {
- var text = this._filterInput.value;
- this._requestHeaderFilterSetting.set(text);
- this._filterRegex = text ? new RegExp(text.escapeForRegExp(), "i") : null;
- this._updateHeaders();
- },
-
- /**
- * @param {!Event} event
- */
- _onFilterKeyDown: function(event)
- {
- var text = this._filterInput.value;
- if (!text)
- return;
- if (event.keyCode === WebInspector.KeyboardShortcut.Keys.Esc.code || event.keyIdentifier === "U+001B") {
- event.consume(true);
- this._filterInput.value = "";
- this._updateFilter();
- }
- },
-
- _updateHeaders: function()
- {
- this._refreshRequestHeaders();
- this._refreshResponseHeaders();
- },
-
wasShown: function()
{
this._request.addEventListener(WebInspector.NetworkRequest.Events.RemoteAddressChanged, this._refreshRemoteAddress, this);
@@ -121,7 +74,8 @@ WebInspector.RequestHeadersView.prototype = {
this._refreshURL();
this._refreshQueryString();
- this._updateHeaders();
+ this._refreshRequestHeaders();
+ this._refreshResponseHeaders();
this._refreshHTTPInformation();
this._refreshRemoteAddress();
},
@@ -345,11 +299,7 @@ WebInspector.RequestHeadersView.prototype = {
_refreshRequestHeaders: function()
{
var treeElement = this._requestHeadersCategory;
-
var headers = this._request.requestHeaders().slice();
- var filterRegex = this._filterRegex;
- if (filterRegex)
- headers = headers.filter(function(header) { return filterRegex.test(header.name) || filterRegex.test(header.value);});
headers.sort(function(a, b) { return a.name.toLowerCase().compareTo(b.name.toLowerCase()); });
var headersText = this._request.requestHeadersText();
@@ -371,9 +321,6 @@ WebInspector.RequestHeadersView.prototype = {
{
var treeElement = this._responseHeadersCategory;
var headers = this._request.sortedResponseHeaders.slice();
- var filterRegex = this._filterRegex;
- if (filterRegex)
- headers = headers.filter(function(header) { return filterRegex.test(header.name) || filterRegex.test(header.value);});
var headersText = this._request.responseHeadersText;
if (this._showResponseHeadersText)
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698