Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 18899002: Initialize ICU data files in d8 and disable i18n for other code samples (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Initialize ICU data files in d8 and disable i18n for other code samples BUG=v8:2745 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15572

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -36 lines) Patch
M samples/lineprocessor.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M samples/process.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M samples/shell.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/d8.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/d8.gyp View 1 2 chunks +10 lines, -0 lines 0 comments Download
A + src/icu_util.h View 1 chunk +9 lines, -12 lines 0 comments Download
A + src/icu_util.cc View 1 chunk +30 lines, -24 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 5 months ago (2013-07-09 12:07:37 UTC) #1
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/18899002/diff/2001/src/icu_util.cc File src/icu_util.cc (right): https://codereview.chromium.org/18899002/diff/2001/src/icu_util.cc#newcode46 src/icu_util.cc:46: if (!module) nit: V8 style prefers ...
7 years, 5 months ago (2013-07-09 12:24:41 UTC) #2
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-09 12:26:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15572 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698