Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1889873003: Code completion tests: 2 additional tests for the is and as expressions. (Closed)

Created:
4 years, 8 months ago by jwren
Modified:
4 years, 8 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Code completion tests: 2 additional tests for the is and as expressions. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/2e877581498dcff518306863d9094eac0197b0ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -15 lines) Patch
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 3 chunks +39 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jwren
This is follow up on https://codereview.chromium.org/1882243003/. I was not able to get a case which ...
4 years, 8 months ago (2016-04-14 18:05:25 UTC) #2
danrubel
LGTM. Thanks!
4 years, 8 months ago (2016-04-14 18:42:06 UTC) #3
jwren
4 years, 8 months ago (2016-04-14 20:28:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e877581498dcff518306863d9094eac0197b0ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698