core/fpdfdoc/doc_basic.cpp - Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/doc_basic.cpp

Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: One last caller. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/doc_basic.cpp

diff --git a/core/fpdfdoc/doc_basic.cpp b/core/fpdfdoc/doc_basic.cpp

index 6d6e5c234f4c8ebbfc5ba703549b25b88a82e93a..a3e94cb033a59235dcf6ec3fd1d67d5c51572b2c 100644

--- a/core/fpdfdoc/doc_basic.cpp

+++ b/core/fpdfdoc/doc_basic.cpp

@@ -482,7 +482,7 @@ CFX_WideString CPDF_PageLabel::GetLabel(int nPage) const {

if (pLabel->KeyExist("P")) {

wsLabel += pLabel->GetUnicodeTextBy("P");

}

- CFX_ByteString bsNumberingStyle = pLabel->GetStringBy("S", NULL);

+ CFX_ByteString bsNumberingStyle = pLabel->GetStringBy("S", nullptr);

int nLabelNum = nPage - n + pLabel->GetIntegerBy("St", 1);

CFX_WideString wsNumPortion =

_GetLabelNumPortion(nLabelNum, bsNumberingStyle);

« no previous file with comments | « core/fpdfdoc/doc_annot.cpp ('k') | core/fpdfdoc/doc_form.cpp » ('j') | no next file with comments »