core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp - Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: One last caller. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

index 48bb667ec7212d1eda89194fb5332a58d553c9f4..940881bacbbe2aae96b0c06846fa84b8a3a22053 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

@@ -427,7 +427,7 @@ CPDF_Object* CPDF_StreamParser::ReadNextObject(FX_BOOL bAllowNestedArray,

return nullptr;

}

if (!key.IsEmpty()) {

- pDict->SetAt(key.AsStringC(), pObj);

+ pDict->SetAt(key, pObj);

} else {

pObj->Release();

}