core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp - Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp

Issue 1889863002: Make CPDF_Dictionary methods take CFX_ByteString arguments (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Avoid more duplication. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp

diff --git a/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp b/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp

index 28cbdfc02e990b385c2129fc8f3f8dd5232fb305..0fff3004efd2d8ca55dc763c153d8b0b868e85cb 100644

--- a/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp

+++ b/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp

@@ -74,7 +74,7 @@ CFX_ByteString CPDF_PageContentGenerator::RealizeResource(

int idnum = 1;

while (1) {

name.Format("FX%c%d", szType[0], idnum);

- if (!pResList->KeyExist(name.AsStringC())) {

+ if (!pResList->KeyExist(name)) {

break;

}

idnum++;