Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1889853002: [heap] Turn on black allocation during marking finalization to avoid floating garbage. (Closed)

Created:
4 years, 8 months ago by Hannes Payer (out of office)
Modified:
4 years, 8 months ago
Reviewers:
ulan
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Turn on black allocation during marking finalization to avoid floating garbage. We will move this back to start of incremental marking when we make faster progress. Perf sheriffs: This CL may cause a regression on benchmarks that improved earlier by enabling black allocation. BUG=chromium:599174 LOG=n Committed: https://crrev.com/413ea9261716511cf09489fcbbec61c9fb65f9a8 Cr-Commit-Position: refs/heads/master@{#35500}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/heap/incremental-marking.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Hannes Payer (out of office)
4 years, 8 months ago (2016-04-14 17:13:01 UTC) #3
ulan
lgtm
4 years, 8 months ago (2016-04-14 17:25:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889853002/20001
4 years, 8 months ago (2016-04-14 17:33:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 17:36:05 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 17:37:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/413ea9261716511cf09489fcbbec61c9fb65f9a8
Cr-Commit-Position: refs/heads/master@{#35500}

Powered by Google App Engine
This is Rietveld 408576698