Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1889803002: [regexp] fix interpreted regexp. (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] fix interpreted regexp. R=ishell@chromium.org Committed: https://crrev.com/808824cc7c3403d35d8ebacf16d76dbaec4df2cf Cr-Commit-Position: refs/heads/master@{#35486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M src/regexp/regexp-macro-assembler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
4 years, 8 months ago (2016-04-14 10:41:42 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889803002/1
4 years, 8 months ago (2016-04-14 10:44:04 UTC) #3
Igor Sheludko
lgtm
4 years, 8 months ago (2016-04-14 10:48:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-14 11:05:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889803002/1
4 years, 8 months ago (2016-04-14 11:24:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 11:26:05 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 11:27:29 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/808824cc7c3403d35d8ebacf16d76dbaec4df2cf
Cr-Commit-Position: refs/heads/master@{#35486}

Powered by Google App Engine
This is Rietveld 408576698