Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1889623002: S390: Fix S390 native build break due to printf format mismatch. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix S390 native build break due to printf format mismatch. size_t defined as unsigned long on 31-bit s390. R=jochen@chromium.org, jfb@chromium.org TBR=ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org BUG= Committed: https://crrev.com/3d861c651be71f65abcf5662cee3a7bc6bdb27ba Cr-Commit-Position: refs/heads/master@{#35457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/profiler/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-13 20:24:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889623002/1
4 years, 8 months ago (2016-04-13 20:26:32 UTC) #3
JF
lgtm
4 years, 8 months ago (2016-04-13 20:41:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 20:49:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889623002/1
4 years, 8 months ago (2016-04-13 23:36:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 23:38:28 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 23:41:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d861c651be71f65abcf5662cee3a7bc6bdb27ba
Cr-Commit-Position: refs/heads/master@{#35457}

Powered by Google App Engine
This is Rietveld 408576698