Fix background compilation disassembly: allocate string in old space instead of new space.

runtime/vm/object.cc

Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index 2ce486b3f00f509a8eec81bd2414fcf498e7bfe0..469462b9510f3453e2273a6f8471122c890bb4fd 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -13740,10 +13740,9 @@ RawString* Code::Name() const {
   if (obj.IsNull()) {
     // Regular stub.
     Thread* thread = Thread::Current();
-    Zone* zone = thread->zone();
     const char* name = StubCode::NameOfStub(EntryPoint());
     ASSERT(name != NULL);
-    const String& stub_name = String::Handle(zone, String::New(name));
+    const String& stub_name = String::Handle(Symbols::New(thread, name));
     return Symbols::FromConcat(thread, Symbols::StubPrefix(), stub_name);

[siva, 2016/04/13 20:29:48]

Why not do:

char* stub_name = OS::Screate(zone, "%s%s", Symbols::StubPrefix().ToCString(),
name);
return Symbols::New(thread, stub_name, strlen(stub_name));

[srdjan, 2016/04/13 20:38:16]

Done.

   } else if (obj.IsClass()) {
     // Allocation stub.