Make libwebp.gyp respect order_profiling mode

Make libwebp.gyp respect order_profiling mode

Currently when order_profiling=1 build flag is set GN would instrument all
libwebp targets and produce the 'orderfile' containing libwebp functions.

This change brings the GYP build on par with GN build with respect to treating
the order_profiling flag. Reasons for having a special case in GYP are
historical and probably not relevant any more.

Performance impact on the GYP build will probably be negligible. It just feels
good to simplify things.

BUG=603618
Committed: https://crrev.com/6d91056b63c00b0911f426859ef907e9f70ee627
Cr-Commit-Position: refs/heads/master@{#387564}

[pasko, 2016-04-14 17:31:52]

pasko@chromium.org changed reviewers:
+ fbarchard@chromium.org

[pasko, 2016-04-14 17:31:52]

PTaL

[urvang, 2016-04-14 17:34:06]

Description was changed from

==========
Make libwebp.gyp respect order_profiling mode

Currently when order_profiling=1 build flag is set GN would instrument all
libwebp targets and produce the 'orderfile' containing libwebp functions.

This change brings the GYP build on par with GN build with respect to treating
the order_profiling flag. Reasons for having a special case in GYP are
historical and probably not relevant any more.

Performance impact on the GYP build will probably be negligible. It just feels
good to simplify things.

BUG=603618
==========

to

==========
Make libwebp.gyp respect order_profiling mode

Currently when order_profiling=1 build flag is set GN would instrument all
libwebp targets and produce the 'orderfile' containing libwebp functions.

This change brings the GYP build on par with GN build with respect to treating
the order_profiling flag. Reasons for having a special case in GYP are
historical and probably not relevant any more.

Performance impact on the GYP build will probably be negligible. It just feels
good to simplify things.

BUG=603618
==========

[urvang, 2016-04-14 17:34:06]

urvang@chromium.org changed reviewers:
+ jzern@chromium.org

[urvang, 2016-04-14 17:34:50]

urvang@chromium.org changed reviewers:
+ urvang@chromium.org

[urvang, 2016-04-14 17:34:50]

Adding jzern@ to look at the gyp change.
I can give OWNER lgtm later if needed.

[jzern, 2016-04-14 17:58:55]

On 2016/04/14 17:34:50, urvang wrote:
> Adding jzern@ to look at the gyp change.
> I can give OWNER lgtm later if needed.

lgtm.

This came from here:
https://chromiumcodereview.appspot.com/8770054

Looking at the thread I didn't see an answer given as to why only those gyp
files were touched.

[pasko, 2016-04-15 08:26:13]

On 2016/04/14 17:58:55, jzern wrote:
> On 2016/04/14 17:34:50, urvang wrote:
> > Adding jzern@ to look at the gyp change.
> > I can give OWNER lgtm later if needed.
> 
> lgtm.
> 
> This came from here:
> https://chromiumcodereview.appspot.com/8770054
> 
> Looking at the thread I didn't see an answer given as to why only those gyp
> files were touched.

Seeing media/skia/webp in the camp I suspect it was due to functions written in
assembly not being handled correctly by the old order_profiling pipeline. We
fixed a ton of problems like these last year.

[pasko, 2016-04-15 08:26:28]

The CQ bit was checked by pasko@chromium.org

[commit-bot: I haz the power, 2016-04-15 08:26:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889513005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889513005/1

[commit-bot: I haz the power, 2016-04-15 09:49:46]

Description was changed from

==========
Make libwebp.gyp respect order_profiling mode

Currently when order_profiling=1 build flag is set GN would instrument all
libwebp targets and produce the 'orderfile' containing libwebp functions.

This change brings the GYP build on par with GN build with respect to treating
the order_profiling flag. Reasons for having a special case in GYP are
historical and probably not relevant any more.

Performance impact on the GYP build will probably be negligible. It just feels
good to simplify things.

BUG=603618
==========

to

==========
Make libwebp.gyp respect order_profiling mode

Currently when order_profiling=1 build flag is set GN would instrument all
libwebp targets and produce the 'orderfile' containing libwebp functions.

This change brings the GYP build on par with GN build with respect to treating
the order_profiling flag. Reasons for having a special case in GYP are
historical and probably not relevant any more.

Performance impact on the GYP build will probably be negligible. It just feels
good to simplify things.

BUG=603618
==========

[commit-bot: I haz the power, 2016-04-15 09:49:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-15 09:51:05]

Description was changed from

==========
Make libwebp.gyp respect order_profiling mode

Currently when order_profiling=1 build flag is set GN would instrument all
libwebp targets and produce the 'orderfile' containing libwebp functions.

This change brings the GYP build on par with GN build with respect to treating
the order_profiling flag. Reasons for having a special case in GYP are
historical and probably not relevant any more.

Performance impact on the GYP build will probably be negligible. It just feels
good to simplify things.

BUG=603618
==========

to

==========
Make libwebp.gyp respect order_profiling mode

Currently when order_profiling=1 build flag is set GN would instrument all
libwebp targets and produce the 'orderfile' containing libwebp functions.

This change brings the GYP build on par with GN build with respect to treating
the order_profiling flag. Reasons for having a special case in GYP are
historical and probably not relevant any more.

Performance impact on the GYP build will probably be negligible. It just feels
good to simplify things.

BUG=603618

Committed: https://crrev.com/6d91056b63c00b0911f426859ef907e9f70ee627
Cr-Commit-Position: refs/heads/master@{#387564}
==========

[commit-bot: I haz the power, 2016-04-15 09:51:06]

Patchset 1 (id:??) landed as
https://crrev.com/6d91056b63c00b0911f426859ef907e9f70ee627
Cr-Commit-Position: refs/heads/master@{#387564}

[pasko, 2016-09-02 10:36:27]

Patchset #2 (id:20001) has been deleted