chrome/browser/push_messaging/background_budget_service_factory.h - Issue 1889513004: Make BackgroundBudgetService a KeyedService

Side by Side Diff: chrome/browser/push_messaging/background_budget_service_factory.h

Issue 1889513004: Make BackgroundBudgetService a KeyedService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ses_integration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/push_messaging/background_budget_service.cc ('K') | « chrome/browser/push_messaging/background_budget_service.cc ('k') | chrome/browser/push_messaging/background_budget_service_factory.cc » ('j') | chrome/browser/push_messaging/background_budget_service_factory.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PUSH_MESSAGING_BACKGROUND_BUDGET_SERVICE_FACTORY_H_

	6 #define CHROME_BROWSER_PUSH_MESSAGING_BACKGROUND_BUDGET_SERVICE_FACTORY_H_

	7

	8 #include "base/memory/singleton.h"

	9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"

	10

	11 class BackgroundBudgetService;

	12

	13 class BackgroundBudgetServiceFactory

	14 : public BrowserContextKeyedServiceFactory {

	15 public:

	16 static BackgroundBudgetService* GetForProfile(

	17 content::BrowserContext* profile);
	Michael van Ouwerkerk 2016/04/14 14:36:31 nit: it seems odd to name an argument of type Brow nit: it seems odd to name an argument of type BrowserContext \|profile\|, I'd expect to see \|context\|. harkness 2016/04/14 17:44:19 I don't really have strong feelings either way, I Show quoted text On 2016/04/14 14:36:31, Michael van Ouwerkerk wrote: > nit: it seems odd to name an argument of type BrowserContext \|profile\|, I'd > expect to see \|context\|. I don't really have strong feelings either way, I just figured the caller is going to be passing in a profile, so it would be more natural. I've updated it.
	18 static BackgroundBudgetServiceFactory* GetInstance();

	19

	20 private:

	21 friend struct base::DefaultSingletonTraits<BackgroundBudgetServiceFactory>;

	22

	23 BackgroundBudgetServiceFactory();

	24 ~BackgroundBudgetServiceFactory() override{};
	Michael van Ouwerkerk 2016/04/14 14:36:31 nit: odd spacing. Did you run format? nit: odd spacing. Did you run format? Peter Beverloo 2016/04/14 16:01:18 also no semi-colon please :-) Show quoted text On 2016/04/14 14:36:31, Michael van Ouwerkerk wrote: > nit: odd spacing. Did you run format? also no semi-colon please :-) harkness 2016/04/14 17:44:19 I did, and I just ran it again with no change. I w Show quoted text On 2016/04/14 14:36:31, Michael van Ouwerkerk wrote: > nit: odd spacing. Did you run format? I did, and I just ran it again with no change. I went ahead and updated the spacing, and ran format again, and it didn't correct it back, so I guess this is just a case format doesn't care about.
	25

	26 KeyedService* BuildServiceInstanceFor(
	Michael van Ouwerkerk 2016/04/14 14:36:31 Add this line above: // BrowserContextKeyedService Add this line above: // BrowserContextKeyedServiceFactory interface. harkness 2016/04/14 17:44:19 Done. Show quoted text On 2016/04/14 14:36:31, Michael van Ouwerkerk wrote: > Add this line above: > // BrowserContextKeyedServiceFactory interface. Done.
	27 content::BrowserContext* profile) const override;
	Michael van Ouwerkerk 2016/04/14 14:36:31 nit: s/profile/context/ nit: s/profile/context/ harkness 2016/04/14 17:44:19 Done. Show quoted text On 2016/04/14 14:36:31, Michael van Ouwerkerk wrote: > nit: s/profile/context/ Done.
	28

	29 DISALLOW_COPY_AND_ASSIGN(BackgroundBudgetServiceFactory);

	30 };

	31

	32 #endif // CHROME_BROWSER_PUSH_MESSAGING_BACKGROUND_BUDGET_SERVICE_FACTORY_H_

OLD	NEW