Make BackgroundBudgetService a KeyedService

chrome/browser/push_messaging/background_budget_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/push_messaging/background_budget_service.h"
 
 #include <stdint.h>
 
 #include "base/callback.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 54 matching lines @@
     return false;
 
   if (!base::StringToDouble(parts[2], old_ses))
     return false;
 
   return true;
 }
 
 }  // namespace
 
+BackgroundBudgetService::BackgroundBudgetService(Profile* profile)
+    : profile_(profile) {
+  DCHECK(profile);
+}
+
 // static
 void BackgroundBudgetService::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterDictionaryPref(prefs::kBackgroundBudgetMap);
 }
 
-// static
-void BackgroundBudgetService::GetBudget(Profile* profile,
-                                        const GURL& origin,
-                                        double& budget) {
+void BackgroundBudgetService::GetBudget(const GURL& origin, double& budget) {
   // Get the current SES score, which we'll use to set a new budget.
-  SiteEngagementService* service = SiteEngagementService::Get(profile);
+  SiteEngagementService* service = SiteEngagementService::Get(profile_);
   double ses_score = service->GetScore(origin);
 
   // Get the last used budget data. This is a triple of last calculated time,
   // budget at that time, and Site Engagement Score (ses) at that time.
-  const std::string map_value = GetBudgetDataFromPrefs(profile, origin);
+  const std::string map_value = GetBudgetDataFromPrefs(profile_, origin);
 
   // If there is no stored data, just return data based on the SES.
   if (map_value.empty()) {
     budget = ses_score;
     return;
   }
 
   double old_budget = 0.0, old_ses = 0.0, last_updated_msec = 0.0;
   if (!GetBudgetDataFromPrefValue(map_value, &old_budget, &old_ses,
                                   &last_updated_msec)) {
@@ skipping 10 matching lines @@
   double carryover_ratio = std::max(
       0.0,
       ((kSecondsToAccumulate - elapsed.InSeconds()) / kSecondsToAccumulate));
   double budget_carryover = old_budget * carryover_ratio;
   double ses_ratio =
       std::min(1.0, (elapsed.InSeconds() / kSecondsToAccumulate));
   double ses_component = (old_ses + ses_score) / 2 * ses_ratio;
   budget = budget_carryover + ses_component;
 }
 
 // static

[Michael van Ouwerkerk, 2016/04/14 14:36:31]

nit: no longer

[harkness, 2016/04/14 17:44:19]

Done.

-void BackgroundBudgetService::StoreBudget(Profile* profile,
-                                          const GURL& origin,
+void BackgroundBudgetService::StoreBudget(const GURL& origin,
                                           const double budget) {
   // Get the current SES score to write into the prefs with the new budget.
-  SiteEngagementService* service = SiteEngagementService::Get(profile);
+  SiteEngagementService* service = SiteEngagementService::Get(profile_);
   double ses_score = service->GetScore(origin);
 
   std::string budget_string = MakePrefValueFromBudgetData(budget, ses_score);
-  SetBudgetDataInPrefs(profile, origin, budget_string);
+  SetBudgetDataInPrefs(profile_, origin, budget_string);
 }