git cl set-commit: for Gerrit + dry-run support.

tests/git_cl_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for git_cl.py."""
 
 import os
 import StringIO
 import stat
@@ skipping 1282 matching lines @@
                                                                                                  'press Enter to continue, Ctrl+C to abort.'],), ''))
     self.assertIsNone(cl.EnsureAuthenticated(force=False))
 
   def test_gerrit_ensure_authenticated_ok(self):
     cl = self._test_gerrit_ensure_authenticated_common(auth={
       'chromium.googlesource.com': 'same',
       'chromium-review.googlesource.com': 'same',
     })
     self.assertIsNone(cl.EnsureAuthenticated(force=False))
 
+  def test_cmd_set_commit_rietveld(self):
+    self.mock(git_cl._RietveldChangelistImpl, 'SetFlag',
+              lambda _, f, v: self._mocked_call(['SetFlag', f, v]))
+    self.calls = [
+        ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
+        ((['git', 'config', 'branch.feature.rietveldissue'],), '123'),
+        ((['git', 'config', 'rietveld.autoupdate'],), ''),
+        ((['git', 'config', 'rietveld.server'],), ''),
+        ((['git', 'config', 'rietveld.server'],), ''),
+        ((['git', 'config', 'branch.feature.rietveldserver'],),
+         'https://codereview.chromium.org'),
+        ((['SetFlag', 'commit', '1'], ), ''),
+    ]
+    self.assertEqual(0, git_cl.main(['set-commit']))

[Sergiy Byelozyorov, 2016/04/13 17:15:03]

also need a test for dry-run here

[tandrii(chromium), 2016/04/13 17:17:16]

see above - don't care about dry-run.

+
+  def test_cmd_set_commit_gerrit(self):
+    self.mock(git_cl.gerrit_util, 'SetReview',
+              lambda h, i, labels: self._mocked_call(
+                  ['SetReview', h, i, labels]))
+    self.calls = [
+        ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
+        ((['git', 'config', 'branch.feature.rietveldissue'],), ''),
+        ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
+        ((['git', 'config', 'branch.feature.gerritserver'],),
+         'https://chromium-review.googlesource.com'),
+        ((['SetReview', 'chromium-review.googlesource.com', 123,
+           {'Commit-Queue': 1}],), ''),
+    ]
+    self.assertEqual(0, git_cl.main(['set-commit', '-d']))

[Sergiy Byelozyorov, 2016/04/13 17:15:03]

do you test non-dry-run scenario?

[tandrii(chromium), 2016/04/13 17:17:16]

no, it's same codepath.

+
 
 if __name__ == '__main__':
   git_cl.logging.basicConfig(
       level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
   unittest.main()