Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1889363002: Fix views_unittests components build (Closed)

Created:
4 years, 8 months ago by hans
Modified:
4 years, 8 months ago
Reviewers:
Fady Samuel, Nico
CC:
chromium-reviews, tfarina, brettw, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix views_unittests components build For some reason the gn build works already. BUG=604034 Committed: https://crrev.com/dda990da6d103f23e814b2e37c9b9c7d1d9aab24 Cr-Commit-Position: refs/heads/master@{#387752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hans
Please take a look.
4 years, 8 months ago (2016-04-15 22:27:29 UTC) #2
Nico
lgtm, thanks! brettw: I don't understand why this works in a gn component build. latency_info ...
4 years, 8 months ago (2016-04-15 22:29:38 UTC) #3
hans
On 2016/04/15 22:29:38, Nico wrote: > lgtm, thanks! > > brettw: I don't understand why ...
4 years, 8 months ago (2016-04-15 22:30:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889363002/1
4 years, 8 months ago (2016-04-15 22:32:04 UTC) #6
Nico
On 2016/04/15 22:30:52, hans wrote: > On 2016/04/15 22:29:38, Nico wrote: > > lgtm, thanks! ...
4 years, 8 months ago (2016-04-15 22:32:32 UTC) #7
Fady Samuel
Thanks! lgtm
4 years, 8 months ago (2016-04-15 22:33:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 23:48:09 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 23:50:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dda990da6d103f23e814b2e37c9b9c7d1d9aab24
Cr-Commit-Position: refs/heads/master@{#387752}

Powered by Google App Engine
This is Rietveld 408576698