Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1889293003: Revert of Version of MessagePumpForUI optimized for GPU process (Closed)

Created:
4 years, 8 months ago by stanisc
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, sadrul, piman+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Version of MessagePumpForUI optimized for GPU process (patchset #8 id:220001 of https://codereview.chromium.org/1714263002/ ) Reason for revert: It looks like this is causing issues with UI responsiveness due to shared message queue. Original issue's description: > Version of MessagePumpForUI optimized for GPU process. > > The purpose of this change is to reduce overhead of > MessagePump in GPU process. According to my testing on > Windows 10 Dell XPS laptop this change improved the > power usage by 0.15 Wt in one test and 0.12 Wt in another. > The test was a windowed playback of 1080p @ 60 Hz H.264 > video. > > Based on ETW sample profile the overhead of the message > pump is reduced from 13-15% to 7-10%. The overhead is > calculated as a number of inclusive samples in DoRunLoop > that are not part of DoWork and DoDelayedWork. > > The change eliminates some system calls that shouldn't be needed > in the context of GPU process such as GetQueueStatus, > SetTimer, KillTimer, and minimizes other system calls that > came up high in the sampling profile - PeekMessage, > MsgWaitForMultipleObjectsEx, PostMessage. > While this version of MessagePump is still capable to peek > and dispatch Windows messages which apparently is needed > in the GPU process on Windows version above Win7, > based on the usage pattern analysis, the emphasis gets > shifted to handling the work (vs. handling Windows messages in MessagePumpForUI). > > See the bug for more details. > > If this work well in a limited context of the GPU process > some of these ideas might later be applied to other > types of MessagePump. > > BUG=588798 > > Committed: https://crrev.com/f71e6d2cbb90cacc88ce41a48475c47c6b7a3543 > Cr-Commit-Position: refs/heads/master@{#386898} TBR=jbauman@chromium.org,thestig@chromium.org,ananta@chromium.org,iyengar@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=588798 Committed: https://crrev.com/06711f5f9fad01f4a9dc89457bfc583b45646a8f Cr-Commit-Position: refs/heads/master@{#387790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -195 lines) Patch
M base/message_loop/message_loop_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_win.h View 5 chunks +6 lines, -40 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 10 chunks +8 lines, -151 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
stanisc
Created Revert of Version of MessagePumpForUI optimized for GPU process
4 years, 8 months ago (2016-04-16 00:23:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889293003/1
4 years, 8 months ago (2016-04-16 00:26:03 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 02:20:46 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 02:23:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06711f5f9fad01f4a9dc89457bfc583b45646a8f
Cr-Commit-Position: refs/heads/master@{#387790}

Powered by Google App Engine
This is Rietveld 408576698