Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1889273002: fix analyzer failures (Closed)

Created:
4 years, 8 months ago by kevmoo
Modified:
4 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M tests/standalone/io/http_proxy_test.dart View 3 chunks +7 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kevmoo
TBR Seems that this code path is not hit – just brings up analyzer errors
4 years, 8 months ago (2016-04-15 18:55:15 UTC) #2
kevmoo
Committed patchset #1 (id:1) manually as fd13a816b76e863a85f8c9313e65105f8491d215 (presubmit successful).
4 years, 8 months ago (2016-04-15 18:55:28 UTC) #4
Søren Gjesse
4 years, 8 months ago (2016-04-18 08:09:29 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698