Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: content/utility/utility_process_control_impl.cc

Issue 1889253002: Remove uses of shell::Loader from content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/utility/utility_process_control_impl.h ('k') | media/mojo/services/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/utility/utility_process_control_impl.cc
diff --git a/content/utility/utility_process_control_impl.cc b/content/utility/utility_process_control_impl.cc
index f717f8687955514df49db1b597ca61ab4e4d3e7d..f6f10f06412076ef8b39fdd1b394603b80642066 100644
--- a/content/utility/utility_process_control_impl.cc
+++ b/content/utility/utility_process_control_impl.cc
@@ -5,7 +5,6 @@
#include "content/utility/utility_process_control_impl.h"
#include "base/bind.h"
-#include "content/common/mojo/static_loader.h"
#include "content/public/common/content_client.h"
#include "content/public/utility/content_utility_client.h"
#include "content/public/utility/utility_thread.h"
@@ -17,37 +16,27 @@
namespace content {
-namespace {
-
-// Called when a static application terminates.
-void QuitProcess() {
- UtilityThread::Get()->ReleaseProcessIfNeeded();
-}
-
-} // namespace
-
UtilityProcessControlImpl::UtilityProcessControlImpl() {}
UtilityProcessControlImpl::~UtilityProcessControlImpl() {}
-void UtilityProcessControlImpl::RegisterLoaders(
- NameToLoaderMap* name_to_loader_map) {
- NameToLoaderMap& map_ref = *name_to_loader_map;
-
+void UtilityProcessControlImpl::RegisterApplicationFactories(
+ ApplicationFactoryMap* factories) {
ContentUtilityClient::StaticMojoApplicationMap apps;
GetContentClient()->utility()->RegisterMojoApplications(&apps);
-
- for (const auto& entry : apps) {
- map_ref[entry.first] =
- new StaticLoader(entry.second, base::Bind(&QuitProcess));
- }
+ for (const auto& entry : apps)
+ factories->insert(std::make_pair(entry.first, entry.second));
#if defined(ENABLE_MOJO_MEDIA_IN_UTILITY_PROCESS)
- map_ref["mojo:media"] = new StaticLoader(
- base::Bind(&media::CreateMojoMediaApplication), base::Bind(&QuitProcess));
+ factories->insert(std::make_pair(
+ "mojo:media", base::Bind(&media::CreateMojoMediaApplication)));
#endif
}
+void UtilityProcessControlImpl::OnApplicationQuit() {
+ UtilityThread::Get()->ReleaseProcessIfNeeded();
+}
+
void UtilityProcessControlImpl::OnLoadFailed() {
UtilityThreadImpl* utility_thread =
static_cast<UtilityThreadImpl*>(UtilityThread::Get());
« no previous file with comments | « content/utility/utility_process_control_impl.h ('k') | media/mojo/services/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698