Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 1889253002: Remove uses of shell::Loader from content (Closed)

Created:
4 years, 8 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo, piman+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove uses of shell::Loader from content Replaces existing uses with the same SCF-based interface used for other shell connections. Adds a manifest for mojo:media (packaged in exe:content_browser) so the shell knows where to route its connections. BUG=601884 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation TBR=xhwang@chromium.org for addition of the app manifest Committed: https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1 Cr-Commit-Position: refs/heads/master@{#387708}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -440 lines) Patch
M content/browser/frame_host/frame_mojo_shell.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/mojo/browser_shell_connection.h View 3 chunks +20 lines, -0 lines 0 comments Download
M content/browser/mojo/browser_shell_connection.cc View 4 chunks +18 lines, -3 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 9 chunks +76 lines, -64 lines 0 comments Download
D content/browser/mojo_shell_browsertest.cc View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M content/child/process_control_impl.h View 1 chunk +16 lines, -16 lines 0 comments Download
M content/child/process_control_impl.cc View 2 chunks +19 lines, -12 lines 0 comments Download
M content/common/mojo/embedded_application_runner.h View 3 chunks +11 lines, -0 lines 0 comments Download
M content/common/mojo/embedded_application_runner.cc View 5 chunks +24 lines, -4 lines 0 comments Download
D content/common/mojo/static_loader.h View 1 chunk +0 lines, -67 lines 0 comments Download
D content/common/mojo/static_loader.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_process_control_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_process_control_impl.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M content/shell/utility/shell_content_utility_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/web_ui_mojo_shell_test.html View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/web_ui_mojo_shell_test.js View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
M content/utility/utility_process_control_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/utility/utility_process_control_impl.cc View 2 chunks +10 lines, -21 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
A media/mojo/services/media_manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Ken Rockot(use gerrit already)
BackgroundShell still uses Loader, but I'll kill that use (and Loader itself) in a follow-up ...
4 years, 8 months ago (2016-04-15 18:30:16 UTC) #4
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-15 19:41:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889253002/40001
4 years, 8 months ago (2016-04-15 20:38:52 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-15 21:46:31 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 21:48:23 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3cc6df2e0b129c29e4e9e02ca290d13ad32b4ae1
Cr-Commit-Position: refs/heads/master@{#387708}

Powered by Google App Engine
This is Rietveld 408576698