chrome/browser/media/android/remote/remote_media_player_manager.h - Issue 1889233002: [Android,VideoFling] Never add null players to alternative ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/android/remote/remote_media_player_manager.h

Issue 1889233002: [Android,VideoFling] Never add null players to alternative ones (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check the result of SwapCurrentPlayer in SwitchToRemotePlayer Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/media/android/remote/remote_media_player_manager.h

diff --git a/chrome/browser/media/android/remote/remote_media_player_manager.h b/chrome/browser/media/android/remote/remote_media_player_manager.h

index 3f09b9e4bd565714175d90cc6f91f189c02bbbd9..0e5173c04f5bdd1961fed54638688f0dadda5a9c 100644

--- a/chrome/browser/media/android/remote/remote_media_player_manager.h

+++ b/chrome/browser/media/android/remote/remote_media_player_manager.h

@@ -104,7 +104,7 @@ class RemoteMediaPlayerManager : public content::BrowserMediaPlayerManager {

// playing remotely.

RemoteMediaPlayerBridge* GetRemotePlayer(int player_id);

- void SwapCurrentPlayer(int player_id);

+ bool SwapCurrentPlayer(int player_id);

void FetchPosterBitmap(int player_id);

« no previous file with comments | « no previous file | chrome/browser/media/android/remote/remote_media_player_manager.cc » ('j') | no next file with comments »