Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188923002: Move RenderViewHost::InsertCSS to RenderFrameHost. (Closed)

Created:
6 years, 9 months ago by Avi (use Gerrit)
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou, jam, nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move RenderViewHost::InsertCSS to RenderFrameHost. BUG=304341 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255657

Patch Set 1 #

Total comments: 7

Patch Set 2 : nasko #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -57 lines) Patch
M chrome/browser/extensions/extension_view_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/frame_messages.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/browser/render_frame_host.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 4 chunks +25 lines, -32 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Avi (use Gerrit)
nasko: IPC jam: all else
6 years, 9 months ago (2014-03-06 18:49:15 UTC) #1
nasko
LGTM with a couple of nits. https://codereview.chromium.org/188923002/diff/1/content/common/frame_messages.h File content/common/frame_messages.h (right): https://codereview.chromium.org/188923002/diff/1/content/common/frame_messages.h#newcode302 content/common/frame_messages.h:302: std::string /* css ...
6 years, 9 months ago (2014-03-06 19:31:54 UTC) #2
Avi (use Gerrit)
https://codereview.chromium.org/188923002/diff/1/content/common/frame_messages.h File content/common/frame_messages.h (right): https://codereview.chromium.org/188923002/diff/1/content/common/frame_messages.h#newcode302 content/common/frame_messages.h:302: std::string /* css string */) On 2014/03/06 19:31:55, nasko ...
6 years, 9 months ago (2014-03-06 21:21:04 UTC) #3
jam
lgtm with comment https://codereview.chromium.org/188923002/diff/1/chrome/browser/extensions/extension_view_host.cc File chrome/browser/extensions/extension_view_host.cc (right): https://codereview.chromium.org/188923002/diff/1/chrome/browser/extensions/extension_view_host.cc#newcode337 chrome/browser/extensions/extension_view_host.cc:337: host_contents()->GetMainFrame()->InsertCSS(css.as_string()); we're sure that doing this ...
6 years, 9 months ago (2014-03-06 21:48:48 UTC) #4
Avi (use Gerrit)
https://codereview.chromium.org/188923002/diff/1/chrome/browser/extensions/extension_view_host.cc File chrome/browser/extensions/extension_view_host.cc (right): https://codereview.chromium.org/188923002/diff/1/chrome/browser/extensions/extension_view_host.cc#newcode337 chrome/browser/extensions/extension_view_host.cc:337: host_contents()->GetMainFrame()->InsertCSS(css.as_string()); On 2014/03/06 21:48:48, jam wrote: > we're sure ...
6 years, 9 months ago (2014-03-06 21:53:22 UTC) #5
Avi (use Gerrit)
yoz, can you double-check the extensions file? This is no change from the behavior you ...
6 years, 9 months ago (2014-03-06 21:55:12 UTC) #6
jam
https://codereview.chromium.org/188923002/diff/1/chrome/browser/extensions/extension_view_host.cc File chrome/browser/extensions/extension_view_host.cc (right): https://codereview.chromium.org/188923002/diff/1/chrome/browser/extensions/extension_view_host.cc#newcode337 chrome/browser/extensions/extension_view_host.cc:337: host_contents()->GetMainFrame()->InsertCSS(css.as_string()); On 2014/03/06 21:53:23, Avi wrote: > On 2014/03/06 ...
6 years, 9 months ago (2014-03-06 21:56:29 UTC) #7
Yoyo Zhou
LGTM for extensions
6 years, 9 months ago (2014-03-06 21:57:48 UTC) #8
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 9 months ago (2014-03-06 22:04:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/188923002/20001
6 years, 9 months ago (2014-03-06 22:34:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 23:02:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg, mac_chromium_rel
6 years, 9 months ago (2014-03-06 23:02:16 UTC) #12
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 9 months ago (2014-03-06 23:06:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/188923002/20001
6 years, 9 months ago (2014-03-06 23:12:15 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 14:49:55 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=277293
6 years, 9 months ago (2014-03-07 14:49:55 UTC) #16
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 9 months ago (2014-03-07 16:14:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/188923002/20001
6 years, 9 months ago (2014-03-07 16:16:31 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 17:59:39 UTC) #19
Message was sent while issue was closed. 
Change committed as 255657

Powered by Google App Engine
This is Rietveld 408576698