Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1889163002: Don't try to render composited selection in throttled frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/sim/SimCompositor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1595 matching lines...) Expand 10 before | Expand all | Expand 10 after
1606 // layout. 1606 // layout.
1607 if (!m_nestedLayoutCount) { 1607 if (!m_nestedLayoutCount) {
1608 updateWidgetGeometries(); 1608 updateWidgetGeometries();
1609 if (LayoutView* layoutView = this->layoutView()) 1609 if (LayoutView* layoutView = this->layoutView())
1610 layoutView->layer()->setNeedsCompositingInputsUpdate(); 1610 layoutView->layer()->setNeedsCompositingInputsUpdate();
1611 } 1611 }
1612 } 1612 }
1613 1613
1614 bool FrameView::computeCompositedSelection(LocalFrame& frame, CompositedSelectio n& selection) 1614 bool FrameView::computeCompositedSelection(LocalFrame& frame, CompositedSelectio n& selection)
1615 { 1615 {
1616 if (frame.view()->shouldThrottleRendering())
1617 return false;
1618
1616 const VisibleSelection& visibleSelection = frame.selection().selection(); 1619 const VisibleSelection& visibleSelection = frame.selection().selection();
1617 if (!visibleSelection.isCaretOrRange()) 1620 if (!visibleSelection.isCaretOrRange())
1618 return false; 1621 return false;
1619 1622
1620 // Non-editable caret selections lack any kind of UI affordance, and 1623 // Non-editable caret selections lack any kind of UI affordance, and
1621 // needn't be tracked by the client. 1624 // needn't be tracked by the client.
1622 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable()) 1625 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
1623 return false; 1626 return false;
1624 1627
1625 VisiblePosition visibleStart(visibleSelection.visibleStart()); 1628 VisiblePosition visibleStart(visibleSelection.visibleStart());
(...skipping 2464 matching lines...) Expand 10 before | Expand all | Expand 10 after
4090 return m_hiddenForThrottling && m_crossOriginForThrottling; 4093 return m_hiddenForThrottling && m_crossOriginForThrottling;
4091 } 4094 }
4092 4095
4093 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const 4096 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
4094 { 4097 {
4095 ASSERT(layoutView()); 4098 ASSERT(layoutView());
4096 return *layoutView(); 4099 return *layoutView();
4097 } 4100 }
4098 4101
4099 } // namespace blink 4102 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/sim/SimCompositor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698