NQE Cleanup in preparation for file splitting

NQE Cleanup in preparation for file splitting

Miscellaneous cleanups:
* Add a new private variable |weight_multiplier_per_second_|,
and reuse it
* Indentation fixes
* Tests cleanup (remove unnecessary tests etc.)

BUG=604091
Committed: https://crrev.com/082edfe90656f27172331c8b579c2a3436e24694
Cr-Commit-Position: refs/heads/master@{#389005}

[tbansal1, 2016-04-16 00:18:30]

Description was changed from

==========
Cleanup

BUG=
==========

to

==========
NQE Cleanup

BUG=604091
==========

[tbansal1, 2016-04-16 00:21:01]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-04-16 00:22:30]

Description was changed from

==========
NQE Cleanup

BUG=604091
==========

to

==========
NQE Cleanup in preparation for file splitting

Miscellaneous cleanups:
* Add a new private variable |weight_multiplier_per_second_|,
and reuse it
* Indentation fixes
* Tests cleanup (remove unnecessary tests etc.)

BUG=604091
==========

[tbansal1, 2016-04-16 00:22:58]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-04-16 00:22:58]

bengr: ptal. Thanks.

[bengr, 2016-04-21 22:00:55]

https://codereview.chromium.org/1889153004/diff/20001/net/base/network_qualit...
File net/base/network_quality_estimator_unittest.cc (left):

https://codereview.chromium.org/1889153004/diff/20001/net/base/network_qualit...
net/base/network_quality_estimator_unittest.cc:503: EXPECT_EQ(100,
(*throughput_iterator).value);
Here and elsewhere I see a bunch of EXPECT statements that have been deleted.
Are these going to be moved to some other file in a later CL? Please explain.

[tbansal1, 2016-04-21 22:06:43]

https://codereview.chromium.org/1889153004/diff/20001/net/base/network_qualit...
File net/base/network_quality_estimator_unittest.cc (left):

https://codereview.chromium.org/1889153004/diff/20001/net/base/network_qualit...
net/base/network_quality_estimator_unittest.cc:503: EXPECT_EQ(100,
(*throughput_iterator).value);
On 2016/04/21 22:00:54, bengr wrote:
> Here and elsewhere I see a bunch of EXPECT statements that have been deleted.
> Are these going to be moved to some other file in a later CL? Please explain.

No they are not going to be moved. They were removed because these statements
are looking at internal data structures which is not required. e.g., 
(1) This test verifies that there is exactly one throughput observation by
looking at the size of the throughput observation buffer
(2) This test then verifies that the median throughput estimate is 1000
(3) It looks at the first element in the observation buffer to see if it
actually 1000 or not.

If (1) and (2) are true, then (3) must be true. So, I removed checks
corresponding to (3). This would help in splitting the files later because now
the test does not care about internal details of ObservationBuffer.

[bengr, 2016-04-21 23:05:24]

lgtm

[tbansal1, 2016-04-22 00:05:09]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-04-22 00:05:22]

The CQ bit was unchecked by tbansal@chromium.org

[tbansal1, 2016-04-22 00:05:42]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2016-04-22 00:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889153004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889153004/20001

[commit-bot: I haz the power, 2016-04-22 00:09:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 00:09:07]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[tbansal1, 2016-04-22 01:18:05]

Patchset #3 (id:60001) has been deleted

[tbansal1, 2016-04-22 01:20:27]

Patchset #3 (id:80001) has been deleted

[tbansal1, 2016-04-22 01:21:36]

Patchset #3 (id:100001) has been deleted

[tbansal1, 2016-04-22 02:13:06]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-04-22 02:13:07]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/1889153004/#ps120001
(title: "rebased")

[commit-bot: I haz the power, 2016-04-22 02:13:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1889153004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1889153004/120001

[commit-bot: I haz the power, 2016-04-22 03:44:57]

Description was changed from

==========
NQE Cleanup in preparation for file splitting

Miscellaneous cleanups:
* Add a new private variable |weight_multiplier_per_second_|,
and reuse it
* Indentation fixes
* Tests cleanup (remove unnecessary tests etc.)

BUG=604091
==========

to

==========
NQE Cleanup in preparation for file splitting

Miscellaneous cleanups:
* Add a new private variable |weight_multiplier_per_second_|,
and reuse it
* Indentation fixes
* Tests cleanup (remove unnecessary tests etc.)

BUG=604091
==========

[commit-bot: I haz the power, 2016-04-22 03:44:58]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-04-22 19:43:31]

Description was changed from

==========
NQE Cleanup in preparation for file splitting

Miscellaneous cleanups:
* Add a new private variable |weight_multiplier_per_second_|,
and reuse it
* Indentation fixes
* Tests cleanup (remove unnecessary tests etc.)

BUG=604091
==========

to

==========
NQE Cleanup in preparation for file splitting

Miscellaneous cleanups:
* Add a new private variable |weight_multiplier_per_second_|,
and reuse it
* Indentation fixes
* Tests cleanup (remove unnecessary tests etc.)

BUG=604091

Committed: https://crrev.com/082edfe90656f27172331c8b579c2a3436e24694
Cr-Commit-Position: refs/heads/master@{#389005}
==========

[commit-bot: I haz the power, 2016-04-22 19:43:32]

Patchset 3 (id:??) landed as
https://crrev.com/082edfe90656f27172331c8b579c2a3436e24694
Cr-Commit-Position: refs/heads/master@{#389005}