Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1889133003: Security: type confusion lead to information leak in decodeURI (Closed)

Created:
4 years, 8 months ago by mvstanton
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Security: type confusion lead to information leak in decodeURI Quit using the global array in uri code. R=yangguo@chromium.org BUG=chromium:602970 LOG=N Committed: https://crrev.com/401450493efc424cd20f914e6df6f69f3d7b8fbc Cr-Commit-Position: refs/heads/master@{#35530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M src/js/uri.js View 4 chunks +3 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-602970.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Yang, PTAL, thx! --Mike
4 years, 8 months ago (2016-04-15 12:35:24 UTC) #1
Yang
On 2016/04/15 12:35:24, mvstanton wrote: > Hi Yang, PTAL, thx! > --Mike LGTM
4 years, 8 months ago (2016-04-15 12:36:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889133003/1
4 years, 8 months ago (2016-04-15 12:40:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 13:08:24 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 13:09:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/401450493efc424cd20f914e6df6f69f3d7b8fbc
Cr-Commit-Position: refs/heads/master@{#35530}

Powered by Google App Engine
This is Rietveld 408576698