Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 1889083002: X87: [generators] Decouple generator resume from fullcodegen. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [generators] Decouple generator resume from fullcodegen. port 974721c66131d208571b8759a1caadf7f995c54c (r35283) original commit message: Introduce a ResumeGeneratorTrampoline, which does the actual stack state reconstruction (currently always restores a fullcodegen frame), and introduce appropriate TurboFan builtins for %GeneratorPrototype%.next, %GeneratorPrototype%.return and %GeneratorPrototype%.throw based on this native builtin. Also unify the flooding in case of step-in to always work based on JSFunction and remove the special casing for JSGeneratorObject. BUG= Committed: https://crrev.com/0e8d220e8b624998c986608433ca82a11e5b1806 Cr-Commit-Position: refs/heads/master@{#35510}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -99 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +10 lines, -99 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-15 06:47:42 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-15 06:50:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889083002/1
4 years, 8 months ago (2016-04-15 07:44:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 08:09:41 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 08:10:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e8d220e8b624998c986608433ca82a11e5b1806
Cr-Commit-Position: refs/heads/master@{#35510}

Powered by Google App Engine
This is Rietveld 408576698