build/config/compiler/BUILD.gn - Issue 1889073002: Revert of Android: Avoid linking with --gc-sections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1889073002: Revert of Android: Avoid linking with --gc-sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 13dea91c1dfbd649b67a92e1e98332b12025b16d..3cf72220237662772be19973c54a9c9de54012fd 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -1246,6 +1246,10 @@

if (!using_sanitizer && target_cpu != "arm64") {

cflags += [ "-fomit-frame-pointer" ]

}

+ # Don't use gc-sections since it can cause links to succeed when they

+ # actually shouldn't. http://crbug.com/159847

+ ldflags = common_optimize_on_ldflags - [ "-Wl,--gc-sections" ]

} else {

cflags = [ "-O0" ]

ldflags = []

« no previous file with comments | « build/common.gypi ('k') | build/config/sanitizers/BUILD.gn » ('j') | no next file with comments »