Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1889073002: Revert of Android: Avoid linking with --gc-sections. (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Yaron, eugenis, agrieve, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Avoid linking with --gc-sections. (patchset #5 id:80001 of https://codereview.chromium.org/1883723004/ ) Reason for revert: May have caused the Android Debug (Nexus 9) GPU bot to go red. FAILED: python ../../build/android/gyp/finalize_apk.py ... Exception in thread "main" java.lang.UnsupportedOperationException: Found more than one library Multiple libraries are not supported for APKs that use 'load_library_from_zip'. Original issue's description: > Android: Avoid linking with --gc-sections. > > No more --gc-sections in debug mode for test targets either. > > Re-enable instrumentation of globals in ASAN builds. > > BUG=159801, 159847 > > Committed: https://crrev.com/6ef23a61fab8467ac15f12173d29ea94b5306101 > Cr-Commit-Position: refs/heads/master@{#387491} TBR=agrieve@chromium.org,eugenis@chromium.org,yfriedman@chromium.org,inferno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=159801, 159847 Committed: https://crrev.com/d842acfbc6f896427c4684ae471aead7e477bf13 Cr-Commit-Position: refs/heads/master@{#387542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M build/common.gypi View 1 chunk +9 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 chunk +10 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
Created Revert of Android: Avoid linking with --gc-sections.
4 years, 8 months ago (2016-04-15 06:38:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889073002/1
4 years, 8 months ago (2016-04-15 06:38:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 06:38:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d842acfbc6f896427c4684ae471aead7e477bf13 Cr-Commit-Position: refs/heads/master@{#387542}
4 years, 8 months ago (2016-04-15 06:40:05 UTC) #6
Yaron
On 2016/04/15 06:40:05, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 7 months ago (2016-05-03 14:05:40 UTC) #7
Lei Zhang
4 years, 7 months ago (2016-05-09 18:59:34 UTC) #8
Message was sent while issue was closed.
On 2016/05/03 14:05:40, Yaron wrote:
> On 2016/04/15 06:40:05, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/d842acfbc6f896427c4684ae471aead7e477bf13
> > Cr-Commit-Position: refs/heads/master@{#387542}
> 
> Lei, any plans to roll this forward?

Ya, will try again when I have time. Probably not this week though. If anyone
else has a better understanding of the finalize_apk.py error, feel free to make
a better CL.

Powered by Google App Engine
This is Rietveld 408576698