third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1889053003: Fix InputConnection.deleteSurroundingText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1889053003: Fix InputConnection.deleteSurroundingText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed the function for multi-code-text, and added some tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 7c1e96e4bfceacbf527432631403a5c6e0578285..758c5917f986e5a2a76e06f477553a5fbd359ea4 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1218,6 +1218,16 @@ void WebLocalFrameImpl::extendSelectionAndDelete(int before, int after)

frame()->inputMethodController().extendSelectionAndDelete(before, after);

}

+void WebLocalFrameImpl::deleteSurroundingText(int before, int after)

+ TRACE_EVENT0("blink", "WebLocalFrameImpl::deleteSurroundingText");

+ if (WebPlugin* plugin = focusedPluginIfInputMethodSupported()) {

+ plugin->deleteSurroundingText(before, after);

+ return;

+ }

+ frame()->inputMethodController().deleteSurroundingText(before, after);

void WebLocalFrameImpl::setCaretVisible(bool visible)

{

frame()->selection().setCaretVisible(visible);