content/browser/renderer_host/ime_adapter_android.cc - Issue 1889053003: Fix InputConnection.deleteSurroundingText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 1889053003: Fix InputConnection.deleteSurroundingText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Deal with multi-code-text, and add more tests. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/ime_adapter_android.cc

diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc

index f41ebefe1cea3797505f2f0a3b3c1ac8d0031872..b11a8df6649e649af92289578b01e10e7a9bdf3e 100644

--- a/content/browser/renderer_host/ime_adapter_android.cc

+++ b/content/browser/renderer_host/ime_adapter_android.cc

@@ -316,7 +316,7 @@ void ImeAdapterAndroid::DeleteSurroundingText(JNIEnv*,

RenderFrameHostImpl* rfh =

static_cast<RenderFrameHostImpl*>(GetFocusedFrame());

if (rfh)

- rfh->ExtendSelectionAndDelete(before, after);

+ rfh->DeleteSurroundingText(before, after);

}

bool ImeAdapterAndroid::RequestTextInputStateUpdate(