third_party/WebKit/Source/core/editing/InputMethodController.h - Issue 1889053003: Fix InputConnection.deleteSurroundingText()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.h

Issue 1889053003: Fix InputConnection.deleteSurroundingText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use a different method to handle "\n" node Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/InputMethodController.h

diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.h b/third_party/WebKit/Source/core/editing/InputMethodController.h

index bf7e152cad58c360be8cf1e35fa5a88e6c2217de..97e1fdf948c961b2b5f738dd3966305191beb132 100644

--- a/third_party/WebKit/Source/core/editing/InputMethodController.h

+++ b/third_party/WebKit/Source/core/editing/InputMethodController.h

@@ -78,6 +78,7 @@ public:

// Returns true if setting selection to specified offsets, otherwise false.

bool setEditableSelectionOffsets(const PlainTextRange&);

void extendSelectionAndDelete(int before, int after);

+ void deleteSurroundingText(size_t before, size_t after);

yosin_UTC9 2016/10/04 09:59:54 Since we use |int| for offset in other member func

yabinh 2016/10/11 03:16:57 Done.

private:

class SelectionOffsetsScope {