Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1889053003: Fix InputConnection.deleteSurroundingText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed the type of some parameters, and added some comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1202 matching lines...) Expand 10 before | Expand all | Expand 10 after
1213 void WebLocalFrameImpl::extendSelectionAndDelete(int before, int after) 1213 void WebLocalFrameImpl::extendSelectionAndDelete(int before, int after)
1214 { 1214 {
1215 TRACE_EVENT0("blink", "WebLocalFrameImpl::extendSelectionAndDelete"); 1215 TRACE_EVENT0("blink", "WebLocalFrameImpl::extendSelectionAndDelete");
1216 if (WebPlugin* plugin = focusedPluginIfInputMethodSupported()) { 1216 if (WebPlugin* plugin = focusedPluginIfInputMethodSupported()) {
1217 plugin->extendSelectionAndDelete(before, after); 1217 plugin->extendSelectionAndDelete(before, after);
1218 return; 1218 return;
1219 } 1219 }
1220 frame()->inputMethodController().extendSelectionAndDelete(before, after); 1220 frame()->inputMethodController().extendSelectionAndDelete(before, after);
1221 } 1221 }
1222 1222
1223 void WebLocalFrameImpl::deleteSurroundingText(int before, int after)
1224 {
1225 TRACE_EVENT0("blink", "WebLocalFrameImpl::deleteSurroundingText");
1226 if (WebPlugin* plugin = focusedPluginIfInputMethodSupported()) {
1227 plugin->deleteSurroundingText(before, after);
1228 return;
1229 }
1230 frame()->inputMethodController().deleteSurroundingText(before, after);
1231 }
1232
1223 void WebLocalFrameImpl::setCaretVisible(bool visible) 1233 void WebLocalFrameImpl::setCaretVisible(bool visible)
1224 { 1234 {
1225 frame()->selection().setCaretVisible(visible); 1235 frame()->selection().setCaretVisible(visible);
1226 } 1236 }
1227 1237
1228 VisiblePosition WebLocalFrameImpl::visiblePositionForViewportPoint(const WebPoin t& pointInViewport) 1238 VisiblePosition WebLocalFrameImpl::visiblePositionForViewportPoint(const WebPoin t& pointInViewport)
1229 { 1239 {
1230 return visiblePositionForContentsPoint(frame()->view()->viewportToContents(p ointInViewport), frame()); 1240 return visiblePositionForContentsPoint(frame()->view()->viewportToContents(p ointInViewport), frame());
1231 } 1241 }
1232 1242
(...skipping 896 matching lines...) Expand 10 before | Expand all | Expand 10 after
2129 return WebSandboxFlags::None; 2139 return WebSandboxFlags::None;
2130 return static_cast<WebSandboxFlags>(frame()->loader().effectiveSandboxFlags( )); 2140 return static_cast<WebSandboxFlags>(frame()->loader().effectiveSandboxFlags( ));
2131 } 2141 }
2132 2142
2133 void WebLocalFrameImpl::forceSandboxFlags(WebSandboxFlags flags) 2143 void WebLocalFrameImpl::forceSandboxFlags(WebSandboxFlags flags)
2134 { 2144 {
2135 frame()->loader().forceSandboxFlags(static_cast<SandboxFlags>(flags)); 2145 frame()->loader().forceSandboxFlags(static_cast<SandboxFlags>(flags));
2136 } 2146 }
2137 2147
2138 } // namespace blink 2148 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698