Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1889053003: Fix InputConnection.deleteSurroundingText() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Deal with multi-code-text, and add more tests. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 2142 matching lines...) Expand 10 before | Expand all | Expand 10 after
2153 2153
2154 void RenderFrameHostImpl::SetFocusedFrame() { 2154 void RenderFrameHostImpl::SetFocusedFrame() {
2155 Send(new FrameMsg_SetFocusedFrame(routing_id_)); 2155 Send(new FrameMsg_SetFocusedFrame(routing_id_));
2156 } 2156 }
2157 2157
2158 void RenderFrameHostImpl::ExtendSelectionAndDelete(size_t before, 2158 void RenderFrameHostImpl::ExtendSelectionAndDelete(size_t before,
2159 size_t after) { 2159 size_t after) {
2160 Send(new InputMsg_ExtendSelectionAndDelete(routing_id_, before, after)); 2160 Send(new InputMsg_ExtendSelectionAndDelete(routing_id_, before, after));
2161 } 2161 }
2162 2162
2163 void RenderFrameHostImpl::DeleteSurroundingText(size_t before, size_t after) {
Changwan Ryu 2016/04/21 01:07:06 This is somewhat inconsistent. How about making th
2164 Send(new InputMsg_DeleteSurroundingText(routing_id_, before, after));
2165 }
2166
2163 void RenderFrameHostImpl::JavaScriptDialogClosed( 2167 void RenderFrameHostImpl::JavaScriptDialogClosed(
2164 IPC::Message* reply_msg, 2168 IPC::Message* reply_msg,
2165 bool success, 2169 bool success,
2166 const base::string16& user_input, 2170 const base::string16& user_input,
2167 bool dialog_was_suppressed) { 2171 bool dialog_was_suppressed) {
2168 GetProcess()->SetIgnoreInputEvents(false); 2172 GetProcess()->SetIgnoreInputEvents(false);
2169 bool is_waiting = is_waiting_for_beforeunload_ack_ || IsWaitingForUnloadACK(); 2173 bool is_waiting = is_waiting_for_beforeunload_ack_ || IsWaitingForUnloadACK();
2170 2174
2171 // If we are executing as part of (before)unload event handling, we don't 2175 // If we are executing as part of (before)unload event handling, we don't
2172 // want to use the regular hung_renderer_delay_ms_ if the user has agreed to 2176 // want to use the regular hung_renderer_delay_ms_ if the user has agreed to
(...skipping 599 matching lines...) Expand 10 before | Expand all | Expand 10 after
2772 // handler after it's destroyed so it can't run after the RFHI is destroyed. 2776 // handler after it's destroyed so it can't run after the RFHI is destroyed.
2773 web_bluetooth_service_->SetClientConnectionErrorHandler(base::Bind( 2777 web_bluetooth_service_->SetClientConnectionErrorHandler(base::Bind(
2774 &RenderFrameHostImpl::DeleteWebBluetoothService, base::Unretained(this))); 2778 &RenderFrameHostImpl::DeleteWebBluetoothService, base::Unretained(this)));
2775 } 2779 }
2776 2780
2777 void RenderFrameHostImpl::DeleteWebBluetoothService() { 2781 void RenderFrameHostImpl::DeleteWebBluetoothService() {
2778 web_bluetooth_service_.reset(); 2782 web_bluetooth_service_.reset();
2779 } 2783 }
2780 2784
2781 } // namespace content 2785 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698