Fix InputConnection.deleteSurroundingText()

third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/InputMethodController.h"
 
 #include "core/dom/Element.h"
 #include "core/dom/Range.h"
 #include "core/editing/FrameSelection.h"
 #include "core/events/MouseEvent.h"
@@ skipping 175 matching lines @@
         insertHTMLElement("<input id='sample' type='password' size='24'>", "sample"));
 
     Vector<CompositionUnderline> underlines;
     underlines.append(CompositionUnderline(0, 5, Color(255, 0, 0), false, 0));
     controller().setComposition("foo", underlines, 0, 3);
     controller().confirmComposition();
 
     EXPECT_STREQ("foo", input->value().utf8().data());
 }
 
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithEmptyText)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("");
+    EXPECT_STREQ("", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 0);
+    EXPECT_STREQ("", input->value().utf8().data());
+
+    input->setValue("");
+    EXPECT_STREQ("", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("", input->value().utf8().data());
+
+    input->setValue("");
+    EXPECT_STREQ("", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ("", input->value().utf8().data());
+
+    input->setValue("");
+    EXPECT_STREQ("", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 1);
+    EXPECT_STREQ("", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithRangeSelection)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(0, 0);
+    EXPECT_STREQ("hello", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(1, 1);
+    EXPECT_STREQ("ell", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(100, 0);
+    EXPECT_STREQ("ello", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(0, 100);
+    EXPECT_STREQ("hell", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 4));
+    controller().deleteSurroundingText(100, 100);
+    EXPECT_STREQ("ell", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithCursorSelection)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("hllo", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ("helo", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(0, 0);
+    EXPECT_STREQ("hello", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(1, 1);
+    EXPECT_STREQ("hlo", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(100, 0);
+    EXPECT_STREQ("llo", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(0, 100);
+    EXPECT_STREQ("he", input->value().utf8().data());
+
+    input->setValue("hello");
+    EXPECT_STREQ("hello", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    controller().deleteSurroundingText(100, 100);
+    EXPECT_STREQ("", input->value().utf8().data());
+
+    input->setValue("h");
+    EXPECT_STREQ("h", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(1, 1));
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("", input->value().utf8().data());
+
+    input->setValue("h");
+    EXPECT_STREQ("h", input->value().utf8().data());
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ("", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithMultiCodeTextOnTheLeft)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    // U+2605 == "black star". It takes up 1 space.
+    input->setValue(String::fromUTF8("foo\xE2\x98\x85"));
+    controller().setEditableSelectionOffsets(PlainTextRange(4, 4));
+    EXPECT_STREQ("foo\xE2\x98\x85", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // U+1F3C6 == "trophy". It takes up 2 space.
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(5, 5));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // composed U+0E01 "ka kai" + U+0E49 "mai tho". It takes up 2 space.
+    input->setValue(String::fromUTF8("foo\xE0\xB8\x81\xE0\xB9\x89"));
+    controller().setEditableSelectionOffsets(PlainTextRange(5, 5));
+    EXPECT_STREQ("foo\xE0\xB8\x81\xE0\xB9\x89", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(7, 7));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(2, 0);
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(7, 7));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(3, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(7, 7));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(4, 0);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(7, 7));
+    EXPECT_STREQ("foo\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(5, 0);
+    EXPECT_STREQ("fo", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithMultiCodeTextOnTheRight)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    // U+2605 == "black star". It takes up 1 space.
+    input->setValue(String::fromUTF8("\xE2\x98\x85 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xE2\x98\x85 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // U+1F3C6 == "trophy". It takes up 2 space.
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // composed U+0E01 "ka kai" + U+0E49 "mai tho". It takes up 2 space.
+    input->setValue(String::fromUTF8("\xE0\xB8\x81\xE0\xB9\x89 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xE0\xB8\x81\xE0\xB9\x89 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 1);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 2);
+    EXPECT_STREQ("\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 3);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 4);
+    EXPECT_STREQ(" foo", input->value().utf8().data());
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo"));
+    controller().setEditableSelectionOffsets(PlainTextRange(0, 0));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86 foo", input->value().utf8().data());
+    controller().deleteSurroundingText(0, 5);
+    EXPECT_STREQ("foo", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextWithMultiCodeTextOnBothSides)
+{
+    HTMLInputElement* input = toHTMLInputElement(
+        insertHTMLElement("<input id='sample'>", "sample"));
+
+    // "trophy" + "trophy".
+    input->setValue(String::fromUTF8("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86"));
+    controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
+    EXPECT_STREQ("\xF0\x9F\x8F\x86\xF0\x9F\x8F\x86", input->value().utf8().data());
+    controller().deleteSurroundingText(1, 1);
+    EXPECT_STREQ("", input->value().utf8().data());
+}
+
+TEST_F(InputMethodControllerTest, DeleteSurroundingTextForMultipleNodes)
+{
+    Element* div = insertHTMLElement(
+        "<div id='sample' contenteditable='true'>"
+        "hello"
+        "<div id='sample2' contenteditable='true'>world</div>"
+        "</div>",
+        "sample");
+
+    controller().setEditableSelectionOffsets(PlainTextRange(6, 6));
+    EXPECT_STREQ("hello\nworld", div->innerText().utf8().data());
+    EXPECT_EQ(6u, controller().getSelectionOffsets().start());
+    EXPECT_EQ(6u, controller().getSelectionOffsets().end());
+

[yabinh, 2016/05/23 10:24:59]

deleteContents doesn’t work well for multiple nodes. It omits the ‘\n’ before
<div> label.

+    // '\n' will not be deleted.
+    controller().deleteSurroundingText(1, 0);
+    EXPECT_STREQ("hello\nworld", div->innerText().utf8().data());
+
+    // '\n' will not be deleted.
+    controller().deleteSurroundingText(2, 0);
+    EXPECT_STREQ("hell\nworld", div->innerText().utf8().data());
+
+    // '\n' can be deleted when the whole node before '\n' is deleted.
+    controller().deleteSurroundingText(5, 0);
+    EXPECT_STREQ("world", div->innerText().utf8().data());
+}
+
 TEST_F(InputMethodControllerTest, SetCompositionForInputWithDifferentNewCursorPositions)
 {
     HTMLInputElement* input = toHTMLInputElement(
         insertHTMLElement("<input id='sample'>", "sample"));
 
     input->setValue("hello");
     controller().setEditableSelectionOffsets(PlainTextRange(2, 2));
     EXPECT_STREQ("hello", input->value().utf8().data());
     EXPECT_EQ(2u, controller().getSelectionOffsets().start());
     EXPECT_EQ(2u, controller().getSelectionOffsets().end());
@@ skipping 163 matching lines @@
     document().setTitle(emptyString());
     controller().setComposition("foo", underlines, 0, 3);
     EXPECT_STREQ("beforeinput.isComposing:true", document().title().utf8().data());
 
     document().setTitle(emptyString());
     controller().confirmComposition();
     EXPECT_STREQ("beforeinput.isComposing:false", document().title().utf8().data());
 }
 
 } // namespace blink